Skip to content

fix: bump electron version to v40.9.3 and add it to our trusted dependencies#2427

Merged
juliusmarminge merged 2 commits into
pingdotgg:mainfrom
nmggithub:electron-v40.9.3-bump
May 1, 2026
Merged

fix: bump electron version to v40.9.3 and add it to our trusted dependencies#2427
juliusmarminge merged 2 commits into
pingdotgg:mainfrom
nmggithub:electron-v40.9.3-bump

Conversation

@nmggithub
Copy link
Copy Markdown
Contributor

@nmggithub nmggithub commented May 1, 2026

What Changed

  1. bumps our electron dependency to v40.9.3
  2. adds electron to our trustedDependencies

Why

  1. This version includes a bug fix for affecting our inputs around macOS text replacements (fix: make macOS text replacement work on contenteditable electron/electron#51345)
  2. Without electron in our trustedDependencies, its postinstall script may fail to run, leaving the dev environment in a broken state.

UI Changes

See electron/electron#50432.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Open in Devin Review

Note

Medium Risk
Upgrades the core Electron runtime for the desktop app, which can affect platform behavior and packaging despite being a patch-level bump. Also changes install-time execution by trusting Electron’s postinstall, which could impact developer/setup flows if misconfigured.

Overview
Bumps the desktop app’s electron dependency from 40.6.0 to 40.9.3.

Marks electron as a trustedDependencies entry (root package.json and bun.lock) so its install scripts can run reliably, and updates bun.lock to reflect the new Electron version.

Reviewed by Cursor Bugbot for commit 08f0c41. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Bump electron to v40.9.3 and add it to trusted dependencies

Updates the electron dependency in apps/desktop/package.json from 40.6.0 to 40.9.3 and adds electron to the trusted dependencies list in the root package.json alongside node-pty.

Macroscope summarized 08f0c41.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 1, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5bcd111a-3c17-44bb-844e-a43656b18f60

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size:XL 500-999 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels May 1, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes May 1, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented May 1, 2026

Approvability

Verdict: Approved

This is a routine patch version bump of electron (40.6.0 → 40.9.3) with no application code changes. Adding electron to trustedDependencies is standard practice for this package.

You can customize Macroscope's approvability policy. Learn more.

@macroscopeapp macroscopeapp Bot dismissed their stale review May 1, 2026 00:12

Dismissing prior approval to re-evaluate 08f0c41

@github-actions github-actions Bot added size:S 10-29 changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels May 1, 2026
@juliusmarminge juliusmarminge merged commit c07ac59 into pingdotgg:main May 1, 2026
11 of 12 checks passed
Morphexe pushed a commit to Morphexe/t3code that referenced this pull request May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants