fix: bump electron version to v40.9.3 and add it to our trusted dependencies#2427
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved This is a routine patch version bump of electron (40.6.0 → 40.9.3) with no application code changes. Adding electron to trustedDependencies is standard practice for this package. You can customize Macroscope's approvability policy. Learn more. |
Dismissing prior approval to re-evaluate 08f0c41
What Changed
electrondependency to v40.9.3electronto ourtrustedDependenciesWhy
contenteditableelectron/electron#51345)electronin ourtrustedDependencies, itspostinstallscript may fail to run, leaving the dev environment in a broken state.UI Changes
See electron/electron#50432.
Checklist
Note
Medium Risk
Upgrades the core Electron runtime for the desktop app, which can affect platform behavior and packaging despite being a patch-level bump. Also changes install-time execution by trusting Electron’s
postinstall, which could impact developer/setup flows if misconfigured.Overview
Bumps the desktop app’s
electrondependency from40.6.0to40.9.3.Marks
electronas atrustedDependenciesentry (rootpackage.jsonandbun.lock) so its install scripts can run reliably, and updatesbun.lockto reflect the new Electron version.Reviewed by Cursor Bugbot for commit 08f0c41. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Bump
electronto v40.9.3 and add it to trusted dependenciesUpdates the
electrondependency in apps/desktop/package.json from 40.6.0 to 40.9.3 and addselectronto the trusted dependencies list in the root package.json alongsidenode-pty.Macroscope summarized 08f0c41.